Skip to content

Increase throttle interval in ToggleVideoButton component#336

Merged
timmydoza merged 3 commits intomasterfrom
adjust-video-button-throttle
Oct 21, 2020
Merged

Increase throttle interval in ToggleVideoButton component#336
timmydoza merged 3 commits intomasterfrom
adjust-video-button-throttle

Conversation

@timmydoza
Copy link
Copy Markdown
Contributor

@timmydoza timmydoza commented Oct 21, 2020 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • NA

Description

This PR increases the throttle interval in the ToggleVideoButton component. This should help to solve the issue described in #262

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza linked an issue Oct 21, 2020 that may be closed by this pull request
Multiple video tracks #262
Closed
charliesantos
charliesantos requested changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@charliesantos charliesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a cleaner way to solve this. Is there a way to check if the video has been turned on/off successfully then update the state? That way, we don't have to rely on throttling button clicks.

@timmydoza
Copy link
Copy Markdown
Contributor Author

timmydoza commented Oct 21, 2020

Maybe there's a cleaner way to solve this. Is there a way to check if the video has been turned on/off successfully then update the state? That way, we don't have to rely on throttling button clicks.

There is a check in useLocalVideoToggle that prevents anything from happening while a camera track is being acquired and published. So nothing will break even if track acquisition & publishing takes longer than the 500ms throttle interval in the button.

https://github.com/twilio/twilio-video-app-react/blob/master/src/hooks/useLocalVideoToggle/useLocalVideoToggle.tsx#L18

Still, for some reason, issues can arise when you repeatedly hit the Mute Video button quickly for a few minutes. Increasing the throttle interval is only meant to prevent this rare edge case.

@timmydoza timmydoza merged commit 7207826 into master Oct 21, 2020
@timmydoza timmydoza deleted the adjust-video-button-throttle branch October 21, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliesantos charliesantos charliesantos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple video tracks

2 participants

@timmydoza @charliesantos